Skip to content

Allow tornado 6.2#7053

Closed
ptrba wants to merge 1 commit into
dask:mainfrom
werkplatz:feature/tornado-6.2
Closed

Allow tornado 6.2#7053
ptrba wants to merge 1 commit into
dask:mainfrom
werkplatz:feature/tornado-6.2

Conversation

@ptrba

@ptrba ptrba commented Sep 21, 2022

Copy link
Copy Markdown

Trying to upgrade to tornado 6.2. Latest tornado upgrade dates back to 2019: #2547.

@GPUtester

GPUtester commented Sep 21, 2022

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@ptrba ptrba marked this pull request as ready for review September 21, 2022 13:28
@github-actions

github-actions Bot commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 14m 15s ⏱️ + 17m 46s
  3 108 tests ±0    3 023 ✔️ +1    85 💤 ±0  0 ❌  - 1 
23 005 runs  ±0  22 098 ✔️ +1  907 💤 +1  0 ❌  - 2 

Results for commit 15e7145. ± Comparison against base commit 34042be.

jrbourbeau
jrbourbeau reviewed Sep 21, 2022
View reviewed changes

@jrbourbeau jrbourbeau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @barmettl. You might be interested in taking a look at #6991 which adds Tornado 6.2 support. There are currently some deprecation warning that need to be resolves -- possibly changes in behavior too

@ptrba

ptrba commented Sep 22, 2022

Copy link
Copy Markdown
Author

Thanks @jrbourbeau, overlooked #6991. Closing this. Looks like the test report for this upgrade is now positive, so #6991 might be ready for merge by now.

@ptrba ptrba closed this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ptrba @GPUtester @jrbourbeau